Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NameError #890

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix NameError #890

merged 2 commits into from
Jan 16, 2024

Conversation

tipabu
Copy link
Contributor

@tipabu tipabu commented Jan 16, 2024

See #826

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e33c6de) 55% compared to head (d4a782d) 55%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff          @@
##           master   #890   +/-   ##
=====================================
  Coverage      55%    55%           
=====================================
  Files          90     90           
  Lines        9855   9950   +95     
  Branches     1827   1845   +18     
=====================================
+ Hits         5438   5536   +98     
+ Misses       4049   4044    -5     
- Partials      368    370    +2
Flag Coverage Δ
ipv6 23% <66%> (+<1%) ⬆️
py310asyncio 52% <100%> (+<1%) ⬆️
py310epolls 53% <100%> (+<1%) ⬆️
py310poll 53% <100%> (+<1%) ⬆️
py310selects 52% <100%> (+<1%) ⬆️
py311asyncio 52% <100%> (+<1%) ⬆️
py311epolls 53% <100%> (+<1%) ⬆️
py312asyncio 50% <100%> (+<1%) ⬆️
py312epolls 50% <100%> (+<1%) ⬆️
py37asyncio 50% <100%> (+<1%) ⬆️
py37epolls 50% <100%> (+<1%) ⬆️
py38asyncio 50% <100%> (+<1%) ⬆️
py38epolls 53% <100%> (+<1%) ⬆️
py38openssl 51% <100%> (+<1%) ⬆️
py38poll 53% <100%> (+<1%) ⬆️
py38selects 52% <100%> (+<1%) ⬆️
py39asyncio 50% <100%> (+<1%) ⬆️
py39dnspython1 51% <100%> (+<1%) ⬆️
py39epolls 53% <100%> (+<1%) ⬆️
py39poll 53% <100%> (+<1%) ⬆️
py39selects 52% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

itamarst
itamarst approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@itamarst itamarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

tipabu
tipabu commented Jan 16, 2024
View reviewed changes
tests/wsgi_test.py Outdated Show resolved Hide resolved
@tipabu tipabu merged commit 881dd62 into eventlet:master Jan 16, 2024
27 checks passed
@tipabu tipabu deleted the wsgi-nameerror branch January 16, 2024 22:58
@jayofdoom
Copy link
Contributor

@itamarst @4383 Can we get this in an eventlet release to unbreak OpenStack Swift?

@4383
Copy link
Member

4383 commented Jan 18, 2024

@jayofdoom: Preparing => #897

openstack-mirroring pushed a commit to openstack/swift that referenced this pull request Jan 18, 2024
@tipabu
Work with latest eventlet (again)
3ab9e45 
See eventlet/eventlet#826 and its follow-up,
eventlet/eventlet#890

Change-Id: I7dff5342013a3f31f19cb410a9f3f6d4b60938f1
openstack-mirroring pushed a commit to openstack/swift that referenced this pull request Jan 18, 2024
@tipabu
tests: Exercise recent eventlet breakage without XFS
e390781 
Recently, upper-constraints updated eventlet. Unfortunately, there
was a bug which breaks our unit tests which was not discovered during
the cross-project testing because the affected unit tests require an
XFS temp dir. The requirements change has since been reverted, but we
ought to have tests that cover the problematic behavior that will
actually run as part of cross-project testing.

See eventlet/eventlet#826 for the eventlet
change that introduced the bug; it has since been fixed on master in
eventlet/eventlet#890 (though we still need
https://review.opendev.org/c/openstack/swift/+/905796 to be able to
work with eventlet master).

Change-Id: I4a6d79317b65f746ee29d2d25073b8c3859cd6a0
pull bot pushed a commit to NeatNerdPrime/openstack that referenced this pull request Jan 18, 2024
@openstack-gerrit
Update git submodules
cad436f 
* Update swift from branch 'master'
  to 03b033f70f0f5cd200fbfd0067b14d81ad316bb0
  - Merge "Work with latest eventlet (again)"
  - Work with latest eventlet (again)
    
    See eventlet/eventlet#826 and its follow-up,
    eventlet/eventlet#890
    
    Change-Id: I7dff5342013a3f31f19cb410a9f3f6d4b60938f1
pull bot pushed a commit to nagyist/openstack that referenced this pull request Jan 19, 2024
@openstack-gerrit
Update git submodules
d1ce6d2 
* Update swift from branch 'master'
  to 52321866d960703c1ef4152440117ad6d84068cd
  - Merge "tests: Exercise recent eventlet breakage without XFS"
  - tests: Exercise recent eventlet breakage without XFS
    
    Recently, upper-constraints updated eventlet. Unfortunately, there
    was a bug which breaks our unit tests which was not discovered during
    the cross-project testing because the affected unit tests require an
    XFS temp dir. The requirements change has since been reverted, but we
    ought to have tests that cover the problematic behavior that will
    actually run as part of cross-project testing.
    
    See eventlet/eventlet#826 for the eventlet
    change that introduced the bug; it has since been fixed on master in
    eventlet/eventlet#890 (though we still need
    https://review.opendev.org/c/openstack/swift/+/905796 to be able to
    work with eventlet master).
    
    Change-Id: I4a6d79317b65f746ee29d2d25073b8c3859cd6a0
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Jan 30, 2024
@4383 @openstack-gerrit
Update git submodules
54ef1e7 
* Update requirements from branch 'master'
  to 08f829d8375b4059af365191e0907069be9fb739
  - Update eventlet to 0.35.0
    
    0.35.0
    ======
    
    eventlet/eventlet#897
    
    * [fix] fix truncate size nullable eventlet/eventlet#789
    * [fix] Handle transport endpoint shutdown in conditions eventlet/eventlet#884
    * [fix] Rework reject_bad_requests option eventlet/eventlet#890
    * [fix] Fix NameError introduced by #826 eventlet/eventlet#890
    * [feature] Support awaiting GreenThread in an `async def` context eventlet/eventlet#889
    * [feature] Asyncio hub support for Python 3.7 to 3.9 eventlet/eventlet#886
    * [fix] Fix bad exceptions handlings eventlet/eventlet#883
    * [feature] Support using asyncio coroutines from inside greenlets eventlet/eventlet#877
    * [removal] Remove deprecated CGIHTTPServer and SimpleHTTPServer eventlet/eventlet#881
    * [feature] Add an asyncio hub for eventlet eventlet/eventlet#870
    
    0.34.3
    ======
    
    eventlet/eventlet#875
    
    * Fix security issue in the wsgi module related to RFC 9112 eventlet/eventlet#826
    * Fix segfault, a new approach for greening existing locks eventlet/eventlet#866
    * greendns: fix getaddrinfo parameter name eventlet/eventlet#809
    * Fix deprecation warning on ssl.PROTOCOL_TLS eventlet/eventlet#872
    * Pytests, fix error at teardown of TestGreenSocket.test_full_duplex eventlet/eventlet#871
    * Skip test which uses Py cgi module eventlet/eventlet#865
    * Drop old code based on python < 3.7.34.2
    ======
    
    eventlet/eventlet#861
    
    * Allowing inheritance of GreenSSLSocket without overriding the __new_ method eventlet/eventlet#796
    * [bug] Fix broken API related to `__version__` removal eventlet/eventlet#859
    * [doc] Fix pypi broken link eventlet/eventlet#857
    
    0.34.1
    ======
    
    eventlet/eventlet#842
    
    * [bug] Fix memory leak in greendns eventlet/eventlet#810
    * [infra] Fix OIDC authentication failure eventlet/eventlet#855
    * [bug] Ignore asyncore and asynchat for Python 3.12+ eventlet/eventlet#804
    
    0.34.0 (Not released on Pypi but landed with 0.34.1)
    ====================================================
    
    * Dropped support for Python 3.6 and earlier.
    * Fix Python 3.13 compat by adding missing attibute '_is_main_interpreter' eventlet/eventlet#847
    * Add support of Python 3.12 eventlet/eventlet#817
    * Drop unmaintained and unused stdlib tests eventlet/eventlet#820
    * Fix tests and CI for Python 3.7 and higher eventlet/eventlet#831 and eventlet/eventlet#832
    * Stop claiming to create universal wheels eventlet/eventlet#841
    * Fix green logging locks for Python versions <= 3.10 eventlet/eventlet#754
    
    Change-Id: I909be1d1812eaed574525866dbc123083684571d
openstack-mirroring pushed a commit to openstack/requirements that referenced this pull request Jan 30, 2024
@4383
Update eventlet to 0.35.0
08f829d 
0.35.0
======

eventlet/eventlet#897

* [fix] fix truncate size nullable eventlet/eventlet#789
* [fix] Handle transport endpoint shutdown in conditions eventlet/eventlet#884
* [fix] Rework reject_bad_requests option eventlet/eventlet#890
* [fix] Fix NameError introduced by #826 eventlet/eventlet#890
* [feature] Support awaiting GreenThread in an `async def` context eventlet/eventlet#889
* [feature] Asyncio hub support for Python 3.7 to 3.9 eventlet/eventlet#886
* [fix] Fix bad exceptions handlings eventlet/eventlet#883
* [feature] Support using asyncio coroutines from inside greenlets eventlet/eventlet#877
* [removal] Remove deprecated CGIHTTPServer and SimpleHTTPServer eventlet/eventlet#881
* [feature] Add an asyncio hub for eventlet eventlet/eventlet#870

0.34.3
======

eventlet/eventlet#875

* Fix security issue in the wsgi module related to RFC 9112 eventlet/eventlet#826
* Fix segfault, a new approach for greening existing locks eventlet/eventlet#866
* greendns: fix getaddrinfo parameter name eventlet/eventlet#809
* Fix deprecation warning on ssl.PROTOCOL_TLS eventlet/eventlet#872
* Pytests, fix error at teardown of TestGreenSocket.test_full_duplex eventlet/eventlet#871
* Skip test which uses Py cgi module eventlet/eventlet#865
* Drop old code based on python < 3.7.34.2
======

eventlet/eventlet#861

* Allowing inheritance of GreenSSLSocket without overriding the __new_ method eventlet/eventlet#796
* [bug] Fix broken API related to `__version__` removal eventlet/eventlet#859
* [doc] Fix pypi broken link eventlet/eventlet#857

0.34.1
======

eventlet/eventlet#842

* [bug] Fix memory leak in greendns eventlet/eventlet#810
* [infra] Fix OIDC authentication failure eventlet/eventlet#855
* [bug] Ignore asyncore and asynchat for Python 3.12+ eventlet/eventlet#804

0.34.0 (Not released on Pypi but landed with 0.34.1)
====================================================

* Dropped support for Python 3.6 and earlier.
* Fix Python 3.13 compat by adding missing attibute '_is_main_interpreter' eventlet/eventlet#847
* Add support of Python 3.12 eventlet/eventlet#817
* Drop unmaintained and unused stdlib tests eventlet/eventlet#820
* Fix tests and CI for Python 3.7 and higher eventlet/eventlet#831 and eventlet/eventlet#832
* Stop claiming to create universal wheels eventlet/eventlet#841
* Fix green logging locks for Python versions <= 3.10 eventlet/eventlet#754

Change-Id: I909be1d1812eaed574525866dbc123083684571d
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Feb 1, 2024
@openstack-gerrit
Update git submodules
959b54c 
* Update swift from branch 'master'
  to 5c659b1a6d31d47faaff1cc0066c732877e04838
  - Merge "Prevent installation of known-broken eventlet"
  - Prevent installation of known-broken eventlet
    
    See eventlet/eventlet#890
    
    It's a relatively minor breakage, triggered by clients hitting a funny
    corner of the HTTP spec, but it does prevent our unit tests from passing
    and may surprise some clients.
    
    Change-Id: Id29ba545e4ac7887c63fa62b75469988a2c6773c
openstack-mirroring pushed a commit to openstack/swift that referenced this pull request Feb 1, 2024
@tipabu
Prevent installation of known-broken eventlet
0d60af2 
See eventlet/eventlet#890

It's a relatively minor breakage, triggered by clients hitting a funny
corner of the HTTP spec, but it does prevent our unit tests from passing
and may surprise some clients.

Change-Id: Id29ba545e4ac7887c63fa62b75469988a2c6773c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamarst itamarst itamarst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tipabu @jayofdoom @4383 @itamarst