Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinlogEntryHandler: cdcDataPublisher should be replaced with Function<EVENT, CompletableFuture...> #82

Open
cer opened this issue Nov 12, 2020 · 0 comments
Open

BinlogEntryHandler: cdcDataPublisher should be replaced with Function<EVENT, CompletableFuture...> #82

cer opened this issue Nov 12, 2020 · 0 comments

Comments

@cer
Copy link
Contributor

cer commented Nov 12, 2020 •
edited
Loading

I don't think there is any reason why BinlogEntryHandler should know about cdcDataPublisher, which is a class.
It would simplify tests if it just took an interface, such as Function<EVENT, CompletableFuture...>

eventuate-cdc/eventuate-local-java-cdc-connector-common/src/main/java/io/eventuate/local/common/BinlogEntryHandler.java

Line 14 in 367f72f

CdcDataPublisher<EVENT> cdcDataPublisher) {

@cer cer changed the title BinlogEntryHandler: cdcDataPublisher should be replaced with Consumer<Event> BinlogEntryHandler: cdcDataPublisher should be replaced with Function<EVENT, CompletableFuture...> Nov 12, 2020
@cer cer mentioned this issue Nov 12, 2020
Merged
dartartem added a commit to dartartem/eventuate-cdc-1 that referenced this issue Nov 13, 2020
@dartartem
eventuate-foundation#82: BinlogEntryHandler: cdcDataPublisher should …
0d8d7b8 
…be replaced with Function<EVENT, CompletableFuture...>. Improved test utils. Optimized tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cer