[Task] Daily Plan | add 'Remove from all plans' option to Action menu #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cedric921
reviewed
Jul 16, 2024
| @@ -8,6 +9,12 @@ export interface IDailyPlanBase extends IBasePerTenantAndOrganizationEntity { | |||
| status: DailyPlanStatusEnum; | |||
| } | |||
|
|
|||
| export class IRemoveTaskFromManyPlans { | |||
There was a problem hiding this comment.
Better to Use Interface instead of Class
There was a problem hiding this comment.
@Innocent-Akim will fix in next PR
delete.all.mov |
|
all right
Le mar. 16 juil. 2024 à 22:13, cedric karungu ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In apps/web/app/interfaces/IDailyPlan.ts
<#2738 (comment)>:
> @@ -8,6 +9,12 @@ export interface IDailyPlanBase extends IBasePerTenantAndOrganizationEntity {
status: DailyPlanStatusEnum;
}
+export class IRemoveTaskFromManyPlans {
@Innocent-Akim <https://github.com/Innocent-Akim> will fix in next PR
—
Reply to this email directly, view it on GitHub
<#2738 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKJO2VSEIJASCNCITMOFADZMV5E5AVCNFSM6AAAAABK5GONEOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBRGIZDENRYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Innocent-Akim please fix merge conflict |
Cedric921
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Task] 'Daily Plan' | add 'Remove from all plans' option to Action menu #2673
Users should be able to remove plans from a specific day as well as from multiple days
'Remove from all plans'
@evereq
@Cedric921