Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging support for ogg #25

Merged
merged 13 commits into from
Aug 11, 2024
Merged

Tagging support for ogg #25

merged 13 commits into from
Aug 11, 2024

Conversation

maya-doshi
Copy link
Contributor

Adds dependencies to generalize tagging, adds support for tagging for a bunch of file types mentioned here.
includes pr #24 even though it isn't strictly required

@everdrone
Copy link
Owner

Thanks for the PR!
There's quite a lot to test here, can you provide some of the URLs you tried this out with?

I'd close #24 in favor of this one after merging

@everdrone
Copy link
Owner

No worries about the commit log.
I noticed there were dependencies missing (music-tag, which requires pillow).

I tested it with the links you provided and probably we will need to update the artwork scraping part for both mixcloud and soundcloud.
I believe soundcloud uses the class .sc-artwork-40x, while it could be trickier to extract it from mixcloud.

For now I'll be merging this.
Thank you

@everdrone everdrone merged commit 3c7dfc2 into everdrone:master Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants