EVG-19928: Update and refresh CI/build versions. #133
Conversation
Update build go go1.19, Ubuntu 22.04, and remove Arch Linux
There was a problem hiding this comment.
This change overall looks good, I just have a question about the overall goals of removing arch dependency - If the goal is to deprecate the arch distros entirely, there's substantially more projects referencing archlinux in their YAMLs than just the ones ticketed out (including non-Evergreen-owned repos). You can get all of them by running evergreen admin all-configs to get the current YAML files and grepping for archlinux-build/test, archlinux-small/large, and archlinux-new-small/large.
docs.go
Outdated
| @@ -1,3 +1,5 @@ | |||
| // nolint:gofmt,goimports | |||
There was a problem hiding this comment.
nit: the //nolint directive shouldn't have a space according to golangci-lint reasoning:
Use //nolint instead of // nolint because machine-readable comments should have no space by Go convention.
|
This is in response to the build ticket here: https://jira.mongodb.org/browse/BUILD-17364 . In any event I'd like to get ahead of it and set a good example. I'll also admit I spent way more time working on the Go upgrade rather than the arch linux removal. |
|
Alright that makes sense. I'm not actually saying we have to go fix the various other projects, but they should all ideally be informed so they don't find out later down the road. I'll list the affected projects on the build ticket. |
evergreen.yaml
Outdated
| expansions: | ||
| GOROOT: /opt/golang/go1.16 | ||
| GOROOT: /opt/golang/go1.19 |
There was a problem hiding this comment.
should we go all the way to 1.20?
Might as well be up to date.
We dropped it from the other upgraded go repos, so we should be consistent.
Update build go go1.19, Ubuntu 22.04, and remove Arch Linux