This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-1970: Migrate CodeChanges Table to LG #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
approved these changes
Mar 21, 2024
| <BaseTable | ||
| data-cy="code-changes-table" | ||
| data-cy-row="code-changes-table-row" | ||
| emptyComponent={<TablePlaceholder message="No diffs." />} |
There was a problem hiding this comment.
[nit] I don't think you need this because we don't show the table if there are no diffs
| dataIndex: "fileName", | ||
| key: "fileName", | ||
| render: (text: string, record: FileDiffsFragment): JSX.Element => ( | ||
| id: "fileName", |
There was a problem hiding this comment.
[nit] You can delete the id fields since they're not used for anything. Other tables use them for sorting, but here they just duplicate the accessorKey field, which is what's used by TanStack table when no id field is provided.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-1970
Description
These code changes swap the antd table for the LG table. Originally the code changes table on the commit queue card didn't include table column headers but I added them back in. I think the table looks better with the headers and it's also kind of complicated styling to not show the table headers and have the table cells respect width props.
Screenshots
New render:
Old render:
