Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TIP-7 specification #19

Closed
wants to merge 2 commits into from

Conversation

pertinaxwallet
Copy link

No description provided.

@ilyar ilyar added the TIP label Mar 22, 2022
@nedobylskiy
Copy link

Hello.

As a developer of one of the wallets, I like the proposed example implementation of the connection standard, but in my opinion it is necessary to discuss a few points before adopting this standard.

  1. First, I saw the description of methods and their parameters, while almost all methods lack a description of the return types when calling a particular method.
  2. The description of the need to check access to a particular method is good, but the final implementation, to check or not should be dependent to wallet developers.
  3. I don't like the idea of the ever_subscribe method because it can cause performance problems in such an implementation. Yes, it's good that it's very universal, and allows you to subscribe to any collection with different filters, but whallet, while keeping tracking of each individual subscription can create a large number of GraphQL requests.

@pertinaxwallet
Copy link
Author

pertinaxwallet commented Mar 22, 2022

About 1.
Is it related to Appendix I: Used function names or to what?
Just if about Appendix I, where lists predefined functions, then let's add output description also. @nedobylskiy
About 2.
The core concepts are that Dapp can't receive some information about environment and user data to aggregate it. That's why the wallet owner must to restrict such access in all cases.
About 3.
ever_subscribe is included to this recommendations to restrict any violation for ever_net_subscribe_collection method. The user must to allow using this method ever_subscribe before DApp can use it. Besides the wallet can add some rate-limit to the own implementation to have only several subscriptions.

@ilyar ilyar mentioned this pull request Mar 23, 2022
15 tasks
@ilyar
Copy link
Contributor

ilyar commented Mar 23, 2022

Must see #13

@ilyar
Copy link
Contributor

ilyar commented Mar 23, 2022

I have not looked in detail yet, I will look later or hopefully more developers of wallets and similar integrations will participate in this process.

Now it is important for me to understand when developing this proposal, was this specification https://eips.ethereum.org/EIPS/eip-1193 taken into account?

@ilyar ilyar changed the title Added TIP-32 specification Added TIP-7 specification Mar 23, 2022
@pertinaxwallet
Copy link
Author

I have not looked in detail yet, I will look later or hopefully more developers of wallets and similar integrations will participate in this process.

Now it is important for me to understand when developing this proposal, was this specification https://eips.ethereum.org/EIPS/eip-1193 taken into account?

Yes, it was created by this approach

@ilyar ilyar added the WEB3 label Jul 29, 2022
@ilyar ilyar marked this pull request as draft November 1, 2022 11:24
@cryshado cryshado closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants