This repository has been archived by the owner on Jul 21, 2024. It is now read-only.
Chapter 10: Fix VCR example #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Freegeoip service that's the default in our current version of the geocoder gem has been discontinued. Geocoder now uses IPInfo.io as its default. Update the geocoder version to 1.4.9 to use the new default. #84
Geocoder now uses the IPInfo.io service as its default for IP-based geocoding, since the previous default service is no longer available. This breaks test examples in chapter 10 of Everyday Rails Testing with RSpec, which uses a geocoding example to record a VCR cassette of network activity. Re-record the cassette to use IPInfo.io. It looks like this service's response is slightly different than the previous service, so update the expected response to reflect that. IPInfo.io doesn't require an API key for less than 1,000 requests a day, and is limited to non-HTTPS requests only. These limitations should be adequate for the sake of demonstration in the book, but should not be used as-is in a production environment. See IPInfo.io's pricing page to acquire an API key for the service. In addition, you'll want to ensure that secrets like API keys are filtered from cassettes when using VCR to record any service requiring an API key, username/password, or other secret. See https://relishapp.com/vcr/vcr/v/3-0-3/docs/configuration/filter-sensitive-data for details on filtering sensitive data in the version of VCR used in the current version of Everyday Rails Testing with RSpec. #84
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempted to run the tests added in chapter 10 since July 1, 2018, you may have noticed that the example using VCR to record an interaction with an external HTTP service no longer works. The IP geocoding service in use before, freegeoip, has been discontinued, and the geocoder gem now defaults to IPInfo.io. Thanks to @JunichiIto for pointing this out to me in #84
This pull request contains code changes necessary to fix this issue, so you can continue to work through examples in the book. I've provided the steps in two standalone commits:
Please click through the commits for additional commentary and to see what's changed from the current book version to now.