Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use const and typed Dicts #9

Merged
merged 1 commit into from
May 25, 2022
Merged

use const and typed Dicts #9

merged 1 commit into from
May 25, 2022

Conversation

visr
Copy link
Collaborator

@visr visr commented May 25, 2022

gftgeom was defined twice, so moved to WellKnownGeometry.jl

@visr
use const and typed Dicts
b7d37e2 
`gftgeom` was defined twice, so moved to WellKnownGeometry.jl
@visr
Copy link
Collaborator Author

visr commented May 25, 2022

Any reason to require julia 1.7 instead of 1.6? a7c0250
This could become a pretty important package to the ecosystem, which mostly still supports the LTS release.
And what do you think about moving it to JuliaGeo?

@evetion
Copy link
Owner

evetion commented May 25, 2022

Findall on a string was only introduced in 1.7. Compat didn't seem to have it, so I released it as is. I'm happy to backport it and make 0.1.1 compatible, for now registration had priority.

I'm fine with moving this to JuliaGeo.

@visr
Copy link
Collaborator Author

visr commented May 25, 2022

Ah yes, just making sure 1.6 was not left out for no reason :)
Glad to see this getting registered.

@evetion evetion merged commit 7a6bbc3 into main May 25, 2022
@evetion evetion mentioned this pull request May 25, 2022
Closed
@visr visr deleted the const branch May 25, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@visr @evetion