Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LogLevel comparisons in Logger #1078

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Fix LogLevel comparisons in Logger #1078

merged 1 commit into from
Oct 27, 2024

Conversation

vittorioromeo
Copy link
Contributor

@vittorioromeo vittorioromeo commented Sep 12, 2022 •
edited
Loading

Changing log level didn't seem to work properly, because the comparisons in Logger.ts such as this.LogLevel <= LogLevel.Error were comparing the string values of LogLevel.

@evilz evilz merged commit c4a0b69 into evilz:master Oct 27, 2024
@evilz
Copy link
Owner

evilz commented Oct 27, 2024

thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vittorioromeo @evilz