Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulties with git-lfs #105

Closed
Sarcasm opened this issue Jan 10, 2024 · 4 comments
Closed

Difficulties with git-lfs #105

Sarcasm opened this issue Jan 10, 2024 · 4 comments

Comments

@Sarcasm
Copy link

Sarcasm commented Jan 10, 2024

Hello,

Seeing the recent improvements, I wanted to update my clone of n2, to run cargo install --path . on it.

I have issues updating my clone due to the git-lfs dependencies for the tests:

$ git pull --rebase
remote: Enumerating objects: 133, done.
remote: Counting objects: 100% (102/102), done.
remote: Compressing objects: 100% (46/46), done.
remote: Total 133 (delta 65), reused 82 (delta 52), pack-reused 31
Receiving objects: 100% (133/133), 54.01 KiB | 6.00 MiB/s, done.
Resolving deltas: 100% (74/74), completed with 19 local objects.
From https://github.com/evmar/n2
   4bae87a..cc45ae4  main       -> origin/main
 * [new branch]      bufwrite   -> origin/bufwrite
Updating 4bae87a..cc45ae4
git-lfs filter-process: git-lfs: command not found
fatal: the remote end hung up unexpectedly

It's not easy for me to add git-lfs to my git install (which is custom built) and I don't plan on developing n2 for now (so I doubt I would make use of the snapshot.zip).

I will look for a way to get the update without git complaining but it's not immediately obvious to me.
I wanted to empty the tests/snapshot/.gitattributes but I cannot do it before the rebase, and doing the rebase aborts in the middle because of the file.

I created this issue to let you know of this potential issue, but I understand it may be working as intended.
If you think it's worth supporting and have ideas on how to make the git-lfs dependency optional, I'm interested.

@Sarcasm
Copy link
Author

Sarcasm commented Jan 10, 2024

FYI, after reading gitattributes documentation I came up with this:

$ cat .git/info/attributes
tests/snapshot/snapshot.zip -filter -diff -merge

Not sure it's optimal but it allowed me to git pull and cargo install.

@evmar
Copy link
Owner

evmar commented Jan 10, 2024

Oh, that is super annoying argh. I don't really need to use git-lfs here so I will probably try to undo it.

I just wanted a place to stash a zip file that some developers occasionally might use, and GitHub doesn't seem to provide one...

@evmar evmar closed this as completed in 164529c Jan 10, 2024
@evmar
Copy link
Owner

evmar commented Jan 10, 2024

(Let me know if this still is busted, I don't have a lot of experience with git lfs)

evmar added a commit that referenced this issue Jan 10, 2024
It's a needless burden for people who don't care about this snapshot.
I switched to Google Drive for now, shruggie.

Fixes #105.
@Sarcasm
Copy link
Author

Sarcasm commented Jan 10, 2024

Looks good.
I could remove the .git/info/attributes after your change and now git pull --rebase does not complain.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants