Enforce only valid rule variables are used #96
Conversation
Regular ninja also has this validation.
evmar
force-pushed
the
main
branch
2 times, most recently
from
8cafbda
to
d43e8ca
Compare
|
I think my just-filed #99 is relevant here: when authoring a tool that generates ninja files this kind of check is useful, but otherwise there's not a much to be gained by being more strict. |
|
Are you saying you want this to be behind a strict flag for performance reasons? Aside from performance I don't think there's any downsides to adding this, seeing as everyone's already complying with it due to the fact ninja has it unconditionally. I haven't benchmarked the performance, but it seems like it should be extremely minor, and not worth potentially making people's lives harder if they started without strict mode and then tried to adopt it later, but had already took advantage of the flexibility. |
|
I think I merged this as part of merging the other one, lemme know if it needs rebasing |
|
Yes, sorry, I don't really know what I'm doing with github pull requests based on top of each other. |
Regular ninja also has this validation.