Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: block gas limit is wrong when adjust base fee #823

Closed
yihuang opened this issue Dec 10, 2021 · 0 comments · Fixed by #832
Closed

Problem: block gas limit is wrong when adjust base fee #823

yihuang opened this issue Dec 10, 2021 · 0 comments · Fixed by #832

Comments

@yihuang
Copy link
Contributor

yihuang commented Dec 10, 2021

System info: ethermint main

Steps to reproduce:

Due to this cosmos-sdk issue: cosmos/cosmos-sdk#10724, the block gas limit will always be math.MaxUint64.

Expected behavior: should fetch real block gas limit.

Actual behavior: always math.MaxUint64

Additional info:

Need to populate the ConsensusParams field in cosmos-sdk.
@yihuang yihuang mentioned this issue Dec 13, 2021
Merged
11 tasks
yihuang added a commit to yihuang/ethermint that referenced this issue Dec 20, 2021
@yihuang
wrong gas limit is wrong when adjust base fee
6b48e35 
Closes: evmos#823
fedekunze added a commit that referenced this issue Jan 3, 2022
@yihuang @fedekunze
fix: wrong gas limit is wrong when adjust base fee (#832)
9f4828e 
Closes: #823

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wrong gas limit when adjust base fee yihuang/ethermint
1 participant
@yihuang