Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

imp(evm): rename RejectUnprotectedTx to AllowUnprotectedTxs #1142

Merged
merged 4 commits into from
Jun 22, 2022
Merged

imp(evm): rename RejectUnprotectedTx to AllowUnprotectedTxs #1142

merged 4 commits into from
Jun 22, 2022

Conversation

fedekunze
Copy link
Contributor

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze marked this pull request as ready for review June 21, 2022 12:57
crypto-facs
crypto-facs approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@crypto-facs crypto-facs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze requested a review from danburck June 22, 2022 10:39
danburck
danburck approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedekunze the rename looks good!

@fedekunze fedekunze merged commit 8e2c652 into main Jun 22, 2022
@fedekunze fedekunze deleted the fedekunze/rename-unprotected branch June 22, 2022 10:51
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Aug 15, 2022
@fedekunze @devon-chain
imp(evm): rename RejectUnprotectedTx to AllowUnprotectedTxs (evmo…
34e73d9 
…s#1142)

* imp(evm): rename RejectUnprotectedTx to AllowUnprotectedTxs

* changelog
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
@fedekunze @devon-chain
imp(evm): rename RejectUnprotectedTx to AllowUnprotectedTxs (evmo…
74828c9 
…s#1142)

* imp(evm): rename RejectUnprotectedTx to AllowUnprotectedTxs

* changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danburck danburck danburck approved these changes

@crypto-facs crypto-facs crypto-facs approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedekunze @danburck @crypto-facs