This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Problem: import/export genesis roundtrip test fails for contract storage #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
changed the title
yihuang
changed the title
yihuang
changed the title
Codecov Report
@@ Coverage Diff @@
## main #590 +/- ##
==========================================
+ Coverage 52.51% 52.60% +0.09%
==========================================
Files 64 64
Lines 5273 5260 -13
==========================================
- Hits 2769 2767 -2
+ Misses 2350 2339 -11
Partials 154 154
|
|
Alternatively, can we just remove the hash in SetState? |
yihuang
force-pushed
the
genesis-import
branch
2 times, most recently
from
4398c4b
to
9589b2f
Compare
I just removed the hash completely in newer commit. |
|
Verified in cronos's integration test: https://github.com/crypto-org-chain/cronos/pull/104/files#diff-4bc634280ffa32d380c3cca748c078f199cf11056710fa67713f672133ebfc86R34 the key in storage is not hashed now. |
done |
fedekunze
approved these changes
Sep 27, 2021
Closes: evmos#589 - don't hash the key again in InitGenesis
auto-merge was automatically disabled
September 27, 2021 09:49
Head branch was pushed to by a user without write access
yihuang
force-pushed
the
genesis-import
branch
from
e58444e
to
6f8dbff
Compare
|
it seems the gas estimate issue is fixed too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #589
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)