Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: need to add rpc endpoint personal_unpair #733

Merged
merged 4 commits into from
Nov 10, 2021
Merged

Problem: need to add rpc endpoint personal_unpair #733

merged 4 commits into from
Nov 10, 2021

Conversation

adu-web3
Copy link
Contributor

@adu-web3 adu-web3 commented Nov 9, 2021 •
edited
Loading

  • this is aimed at smartcard wallet which is not supported yet.

  • will return unsupported error now.

Closes: #730

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@adu-web3
Problem: need to add rpc endpoint personal_unpair
eb5daac 
Closes evmos#730

* this is aimed at smartcard wallet which is not supported yet.

* will return unsupported error now.
leejw51crypto
leejw51crypto approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fedekunze
fedekunze approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Minor comments, can you also add a changelog entry?

rpc/ethereum/namespaces/personal/api.go Outdated Show resolved Hide resolved
tests/rpc/personal_test.go Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit a3f1d8d into evmos:main Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leejw51crypto leejw51crypto leejw51crypto approved these changes

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: need to add rpc endpoint personal_unpair
4 participants
@adu-web3 @fedekunze @leejw51crypto @tomtau