This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Fix get block #781
Merged
Fix get block #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-facs
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
| if err != nil || ethTx.Height != block.Height { | ||
| e.logger.Debug("failed to query eth tx", "hash", tx.Hash().Hex()) | ||
| // check tx exists on EVM by cross checking with blockResults | ||
| if txResults[i].Code != 0 { |
There was a problem hiding this comment.
if Code is not 0, it's EVM tx?
maybe add some comment about it
There was a problem hiding this comment.
if Code != 0, it's a failed transaction.
fedekunze
added
backport/0.17.x
fedekunze
reviewed
Nov 25, 2021
fedekunze
approved these changes
Nov 26, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2021
(cherry picked from commit bfe059e) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2021
(cherry picked from commit bfe059e) # Conflicts: # CHANGELOG.md # rpc/ethereum/backend/backend.go
leejw51crypto
pushed a commit
to leejw51crypto/ethermint
that referenced
this pull request
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #778
Description
We were seeing an issue where some txs where not being indexed on our indexer without any noticeable errors. @yihuang noticed that tx Indexer runs asynchronously with block commit. This leads to unexepected behaviour since
eth_getBlockByNumbercurrently cross checks valid txs based on the tx Indexer.resultBlockis on sync with block commit so it provides a better approach to remove failed transactions from the block response.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)