Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

NobaseFee value should be consistent with height #831

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

thomas-nguy
Copy link
Contributor

Closes: #XXX

Description

NoBaseFee value should be the value at the specified height

The problem arise when NoBaseFee value is changed through governance vote, current code can return some inconsistence when used in "GetBlockByX"


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy changed the title NobaseFee return value should be consistent with block height NobaseFee value should be consistent with block height Dec 13, 2021
@thomas-nguy thomas-nguy changed the title NobaseFee value should be consistent with block height NobaseFee value should be consistent with height Dec 13, 2021
@fedekunze fedekunze enabled auto-merge (squash) December 13, 2021 19:15
@fedekunze fedekunze merged commit 4ee1d86 into evmos:main Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants