Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added Ethermint params upgrade fix #1242

Merged
merged 7 commits into from
Jan 13, 2023

Conversation

Vvaradinov
Copy link
Contributor

@Vvaradinov Vvaradinov commented Jan 12, 2023

Description

This PR uses the most recent main branch of Ethermint to include reverted changes to TypedEvents and duplicate proto fixes to fix the v11 upgrade on Evmos. A separate issue was made to replace Ethermint back with a release version #1240


Closes #XXX

@Vvaradinov Vvaradinov marked this pull request as ready for review January 12, 2023 21:21
@Vvaradinov Vvaradinov requested a review from a team as a code owner January 12, 2023 21:21
@Vvaradinov Vvaradinov requested review from MalteHerrmann and adisaran64 and removed request for a team January 12, 2023 21:21
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1242 (a1257a3) into main (f7af0ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a1257a3 differs from pull request most recent head 4277177. Consider uploading reports for the commit 4277177 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1242   +/-   ##
=======================================
  Coverage   76.32%   76.33%           
=======================================
  Files         149      149           
  Lines        8280     8283    +3     
=======================================
+ Hits         6320     6323    +3     
  Misses       1768     1768           
  Partials      192      192           
Impacted Files Coverage Δ
app/app.go 82.18% <100.00%> (+0.06%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Vvaradinov Vvaradinov enabled auto-merge (squash) January 13, 2023 12:39
@Vvaradinov Vvaradinov merged commit d4b066b into main Jan 13, 2023
@Vvaradinov Vvaradinov deleted the Vvaradinov/fix-ethermint-module-upgrades branch January 13, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants