Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ics20): timeout height as const #1917

Merged
merged 4 commits into from
Oct 20, 2023
Merged

chore(ics20): timeout height as const #1917

merged 4 commits into from
Oct 20, 2023

Conversation

0xstepit
Copy link
Contributor

Description

This PR:

  • adds the DefaultTimeoutHeight as a constant value in the precompile ics20 package.
  • substitute the hardcode value of timeout height in Stride outpost with the default value.

Closes #XXX

@0xstepit 0xstepit requested a review from a team as a code owner October 20, 2023 09:47
@0xstepit 0xstepit requested review from Vvaradinov and GAtom22 and removed request for a team October 20, 2023 09:47
Vvaradinov
Vvaradinov approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vvaradinov Vvaradinov enabled auto-merge (squash) October 20, 2023 10:07
@Vvaradinov Vvaradinov merged commit ba79d37 into main Oct 20, 2023
26 checks passed
@Vvaradinov Vvaradinov deleted the stepit/ics20-timeout branch October 20, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xstepit @Vvaradinov