Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(upgrade): Prepare v15.0.0 upgrade #1972

Merged
merged 11 commits into from
Oct 31, 2023

Conversation

MalteHerrmann
Copy link
Contributor

Description

This PR prepares the v15.0.0 upgrade by re-adding the necessary upgrade logic for the migrations and enabling EIP-3855 plus adjusts the changelog accordingly and removes the v15.0.0-rc2 specific logic.


Closes ENG-2261

@linear
Copy link

linear bot commented Oct 31, 2023

ENG-2261 Implement Upgrade Logic

Ensure, that the necessary upgrade logic is added as well as corresponding tests.

  • Upgrade handler is defined in app/upgrades/… (e.g. v14.0.0-rc5)
  • Upgrade handler is added in app.go (e.g. v14.0.0-rc5)
  • Store migration is defined in app.go (e.g. v14.0.0-rc2)
  • UpgradeName in constants.go must match the release number (e.g. v14.0.0-rc5)
  • Upgrade logic has tests (e.g. v14.0.0-rc5)

In case an offline upgrade has to be executed:

  • define the UpgradeHeight (e.g. v8.2.0).

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1972 (daf921a) into release/v15.0.x (28feae6) will decrease coverage by 0.04%.
The diff coverage is 27.27%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v15.0.x    #1972      +/-   ##
===================================================
- Coverage            70.36%   70.33%   -0.04%     
===================================================
  Files                  319      319              
  Lines                23525    23533       +8     
===================================================
- Hits                 16554    16551       -3     
- Misses                6149     6162      +13     
+ Partials               822      820       -2     
Files Coverage Δ
app/app.go 80.79% <54.54%> (-0.33%) ⬇️
tests/e2e/upgrade/manager.go 0.00% <0.00%> (ø)
app/upgrades/v15/upgrades.go 23.07% <23.07%> (ø)

app/upgrades/v15/upgrades.go Show resolved Hide resolved
app/upgrades/v15/upgrades_test.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
@github-actions github-actions bot added the tests label Oct 31, 2023
GAtom22 and others added 2 commits October 31, 2023 15:33
* chore: update precompiles file name to match the interface naming convention

* add changelog entry
@GAtom22 GAtom22 marked this pull request as ready for review October 31, 2023 18:57
@GAtom22 GAtom22 requested a review from a team as a code owner October 31, 2023 18:57
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @MalteHerrmann !!

@MalteHerrmann MalteHerrmann merged commit ba5b8a3 into release/v15.0.x Oct 31, 2023
24 of 26 checks passed
@MalteHerrmann MalteHerrmann deleted the malte/prepare-v15.0.0 branch October 31, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants