Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(erc20): ERC-20 transactions #1993

Merged
merged 3 commits into from Nov 3, 2023
Merged

feat(erc20): ERC-20 transactions #1993

merged 3 commits into from Nov 3, 2023

Conversation

fedekunze
Copy link
Contributor

Description

Closes #XXX

@fedekunze fedekunze marked this pull request as ready for review November 3, 2023 10:39
@fedekunze fedekunze requested a review from a team as a code owner November 3, 2023 10:39
@fedekunze fedekunze requested review from Vvaradinov and MalteHerrmann and removed request for a team November 3, 2023 10:39
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited

Codecov Report

Merging #1993 (2391f86) into main (89b3b81) will decrease coverage by 0.45%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 2391f86 differs from pull request most recent head da9408f. Consider uploading reports for the commit da9408f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1993      +/-   ##
==========================================
- Coverage   69.75%   69.31%   -0.45%     
==========================================
  Files         332      333       +1     
  Lines       24618    24683      +65     
==========================================
- Hits        17173    17108      -65     
- Misses       6561     6691     +130     
  Partials      884      884
Files Coverage Δ
precompiles/erc20/tx.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

0xstepit
0xstepit approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@fedekunze fedekunze enabled auto-merge (squash) November 3, 2023 13:54
@fedekunze fedekunze merged commit 8582d16 into main Nov 3, 2023
26 of 27 checks passed
@fedekunze fedekunze deleted the fedekunze/erc20-txs branch November 3, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xstepit 0xstepit 0xstepit approved these changes

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov Vvaradinov is a code owner automatically assigned from evmos/core-engineering

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fedekunze @0xstepit