Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(str-v2): Add Event after successful ERC20 extension registration #2411

Conversation

Vvaradinov
Copy link
Contributor

Description

This PR adds an event after successful ERC20 extension registration.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@Vvaradinov Vvaradinov requested a review from a team as a code owner March 13, 2024 13:50
@Vvaradinov Vvaradinov requested review from facs95 and 0xstepit and removed request for a team March 13, 2024 13:50
@github-actions github-actions bot added the tests label Mar 13, 2024
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding @Vvaradinov - would love to see a test for this though :)

x/erc20/keeper/ibc_callbacks.go Show resolved Hide resolved
x/erc20/types/events.go Show resolved Hide resolved
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test! 🙏 there are some print statements left that can probably be removed but other than that looks great 🚀

x/erc20/keeper/ibc_callbacks_test.go Outdated Show resolved Hide resolved
@Vvaradinov Vvaradinov merged commit a0f506c into Vvaradinov/feat-strv2-feature-branch Mar 20, 2024
34 of 35 checks passed
@Vvaradinov Vvaradinov deleted the Vvaradinov/register-extension-event branch March 20, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants