Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonrpc): add support for allow-insecure-unlock (backport #2375) #2580

Closed
wants to merge 4 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 27, 2024

Allow insecure account unlocking when account-related RPCs are exposed by http

Description

Closes: #1657


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

This is an automatic backport of pull request #2375 done by [Mergify](https://mergify.com).

* feat: impl geth allow-insecure-unlock

Allow insecure account unlocking when account-related RPCs are exposed by http

* fix: Solidity Test error

* remove JSONRPC.Enable check

1.remove JSONRPC.Enable check
2.add changelog
3.modify JSONRPC.Enable description

* change log type

* Update CHANGELOG.md

* fix lint issues

* fix test-nix error

* fix: test error

* Update init-node.sh

* Update CHANGELOG.md

Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>

* fix: solidity test error

* fix: rpc test error

* Update server/config/config.go

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>

* Update local_node.sh

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>

* remove duplicated file

* set default value to true to ensure backwards compatibility

* remove unnecessary change

---------

Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Freddy Caceres <facs95@gmail.com>
Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
(cherry picked from commit 0c5f7db)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from a team as a code owner May 27, 2024 19:59
@mergify mergify bot added the conflicts label May 27, 2024
Copy link
Contributor Author

mergify bot commented May 27, 2024

Cherry-pick of 0c5f7db has failed:

On branch mergify/bp/release/v18.0.x/pr-2375
Your branch is up to date with 'origin/release/v18.0.x'.

You are currently cherry-picking commit 0c5f7db6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rpc/backend/backend_suite_test.go
	modified:   rpc/backend/node_info.go
	modified:   rpc/backend/sign_tx.go
	modified:   server/config/config.go
	modified:   server/config/toml.go
	modified:   server/flags/flags.go
	modified:   server/start.go
	modified:   tests/nix_tests/configs/default.jsonnet

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@GAtom22
Copy link
Contributor

GAtom22 commented May 29, 2024

close in favor of #2587

@GAtom22 GAtom22 closed this May 29, 2024
@GAtom22 GAtom22 deleted the mergify/bp/release/v18.0.x/pr-2375 branch May 29, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants