feat(jsonrpc): add support for allow-insecure-unlock (#2375) #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: impl geth allow-insecure-unlock Allow insecure account unlocking when account-related RPCs are exposed by http * fix: Solidity Test error * remove JSONRPC.Enable check 1.remove JSONRPC.Enable check 2.add changelog 3.modify JSONRPC.Enable description * change log type * Update CHANGELOG.md * fix lint issues * fix test-nix error * fix: test error * Update init-node.sh * Update CHANGELOG.md Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> * fix: solidity test error * fix: rpc test error * Update server/config/config.go Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * Update local_node.sh Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com> * remove duplicated file * set default value to true to ensure backwards compatibility * remove unnecessary change --------- Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Freddy Caceres <facs95@gmail.com> Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: tom <tomasguerraalda@hotmail.com>
Vvaradinov
approved these changes
May 29, 2024
GAtom22
approved these changes
May 29, 2024
Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md