-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: boilerplate for IBC modules #412
Conversation
Codecov Report
@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 78.65% 78.91% +0.26%
==========================================
Files 97 99 +2
Lines 5579 5592 +13
==========================================
+ Hits 4388 4413 +25
+ Misses 1035 1022 -13
- Partials 156 157 +1
|
ENG-85 IBC module boilerplate interface
Create an IBC boilerplate in order to reduce code maintenance |
|
||
module := NewModule(mockModule) | ||
|
||
// mock calls for abstraction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can clarify that these are all pretty much no-ops
Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com>
Description
Closes: ENG-85
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...