Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!fix(app): fix store loader #918

Merged
merged 7 commits into from
Sep 22, 2022
Merged

!fix(app): fix store loader #918

merged 7 commits into from
Sep 22, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Sep 21, 2022

Description

Closes: #919


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #918 (0fef587) into main (10f5a18) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   80.60%   80.57%   -0.04%     
==========================================
  Files         128      128              
  Lines        7312     7335      +23     
==========================================
+ Hits         5894     5910      +16     
- Misses       1277     1284       +7     
  Partials      141      141              
Impacted Files Coverage Δ
app/app.go 83.02% <66.66%> (-0.43%) ⬇️

@fedekunze fedekunze marked this pull request as ready for review September 21, 2022 22:33
@fedekunze fedekunze requested a review from a team as a code owner September 21, 2022 22:33
@fedekunze fedekunze requested review from 0a1c and adisaran64 and removed request for a team September 21, 2022 22:33
@fedekunze fedekunze changed the title fix(app): fix store loader !fix(app): fix store loader Sep 21, 2022
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedekunze Overall looks good, please check my comment on the binaries

app/upgrades/v8_2/constants.go Outdated Show resolved Hide resolved
app/upgrades/v8_2/constants.go Outdated Show resolved Hide resolved
app/upgrades/v8_2/constants.go Outdated Show resolved Hide resolved
@danburck danburck linked an issue Sep 22, 2022 that may be closed by this pull request
4 tasks
@github-actions github-actions bot added the docs label Sep 22, 2022
@fedekunze fedekunze merged commit 19f6775 into main Sep 22, 2022
@fedekunze fedekunze deleted the fedekunze/fix-store-loader branch September 22, 2022 09:14
@danburck
Copy link
Contributor

@fedekunze wht did you remove the binarer from the go releaser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to 8.1.0 failed for 'panic: cannot delete latest saved version (1)' v8.1 Upgrade: feesplit module
2 participants