-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(all): Add EVM, ERC-20, feemarket and precompiles from Evmos #37
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe recent changes involve a significant restructuring of the codebase, primarily focusing on the import paths and dependencies related to the Ethereum Virtual Machine (EVM) components. Additionally, modifications include the introduction of new functionalities for IBC (Inter-Blockchain Communication), updates to the genesis and fee management, and enhancements in the test suite to ensure better alignment with the new architecture. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EVM
participant IBC
participant Chain
User->>+Chain: Send Transaction
Chain->>+EVM: Process EVM Transaction
EVM->>IBC: Check Cross-Chain Interaction
IBC-->>-EVM: Return Status
EVM-->>-Chain: Transaction Result
Chain-->>-User: Response
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @MalteHerrmann!!
Left one nit comment
This PR adds the EVM, ERC-20 and feemarket modules as well as the precompiles and test utilities. It was too much unnecessary work to untangle all of the individual dependencies only to rework those when porting the next module so all of these were moved on this PR.
There had to be some mandatory changes to the codebase though, when it comes to making the implementation available to use with other chains. I will mention the most important changes below here:
utils.BaseDenom
. Now we're querying the EVM denomination for that -> https://github.com/evmos/os/pull/37/files#diff-107abfa12b8c3ab8f6ecac71109a0aa678dcc02314a005babe7bd4d427d41c3dR59-R78 and https://github.com/evmos/os/pull/37/files#diff-6173a3fe50a9547a7572bdd81215fcfc8e2ab89a10c6109299b196a0f42bac8cR77-R85Summary by CodeRabbit
New Features
Documentation
Refactor
Bug Fixes
Tests