Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Up / invalid values response #18

Closed
dunaevskiy opened this issue Nov 3, 2018 · 1 comment
Closed

Sign Up / invalid values response #18

dunaevskiy opened this issue Nov 3, 2018 · 1 comment
Assignees
Labels
fixme Fix me please resolved

Comments

@dunaevskiy
Copy link

dunaevskiy commented Nov 3, 2018

Request:

{
   "email" : "",
   "password" : "",
   "username" : ""
}

Současné chování:
Po detekování nevalidní hodnoty v requestu ihned vrací odpověd, bez kontroly všech hodnot:

{
   "message" : "...",
   "invalid": [ "email" ]
}

Očekávané chování:
Kontrola všech hodnot a návrat všech nevalidních hodnot:

{
   "message" : "...",
   "invalid": [ "username", "email", "password"]
}
@dunaevskiy dunaevskiy added the bug Something isn't working label Nov 3, 2018
@dunaevskiy dunaevskiy added fixme Fix me please and removed bug Something isn't working labels Nov 3, 2018
@dunaevskiy dunaevskiy changed the title /auth/signup Sign Up / invalid values response Nov 3, 2018
DanHampl added a commit that referenced this issue Nov 3, 2018
@DanHampl DanHampl mentioned this issue Nov 3, 2018
Merged
@DanHampl
Copy link
Member

DanHampl commented Nov 3, 2018

fixed in #21

@DanHampl DanHampl closed this as completed Nov 3, 2018
TomStary pushed a commit that referenced this issue Nov 3, 2018
* API/422 #13

* decorators initialized

* flake8

* token fix for issue #17

* flake8 import error

* fix for issue #18

* temporary pasword validation

* flake8 cleanup
DanHampl added a commit that referenced this issue Nov 3, 2018
TomStary pushed a commit that referenced this issue Nov 3, 2018
* API/422 #13

* decorators initialized

* flake8

* token fix for issue #17

* flake8 import error

* fix for issue #18

* temporary pasword validation

* flake8 cleanup

* username validation

* decorators initialized

* flake8

* token fix for issue #17

* flake8 import error

* fix for issue #18

* temporary pasword validation

* flake8 cleanup

* username validation

* password validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixme Fix me please resolved
Projects
None yet
Development

No branches or pull requests

2 participants