Prevent event notifications from being suppressed if logging for the given event happens to be disabled #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior as specified doesn't make any sense, as it conflates the event log with the actual event registry. Disabling logging should of course not disable notifications as that would completely break any code that expects to get notified. Maybe this is a sign the intent needs to be made clearer, seeing how the "minimal" naming convention selected here (which is typically used in Lua and C) doesn't sufficiently express this nuance. Will have to consider this when streamlining the API...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior as specified doesn't make any sense, as it conflates the event log with the actual event registry. Disabling logging should of course not disable notifications as that would completely break any code that expects to get notified.
Maybe this is a sign the intent needs to be made clearer, seeing how the "minimal" naming convention selected here (which is typically used in Lua and C) doesn't sufficiently express this nuance. Will have to consider this when streamlining the API...