Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an AsyncFileReader module to the FileSystem API #533

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

rdw-software
Copy link
Member

This module makes heavy use of the event system to flatten the hierarchy of nested callbacks and make things easier to test/observe. Not sure how much I like the design, but it's arguably less convoluted than playing ping-pong with coroutines and should be relatively easy to use, as well. Additional features, like gathering multiple files, can be added on top of this later.

This is just a quick-and-dirty test to determine default chunk sizes and ensure that the async reader is actually a net gain for larger workloads.
This module makes heavy use of the event system to flatten the hierarchy of nested callbacks and make things easier to test/observe. Not sure how much I like the design, but it's arguably less convoluted than playing ping-pong with coroutines and should be relatively easy to use, as well. Additional features, like gathering multiple files, can be added on top of this later.
Reading directories succeeds with no data here, which doesn't make for a very consistent interface to program against.
@rdw-software rdw-software merged commit c16d1a3 into main Feb 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant