Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
{{svg-jar}}
helper, optional named arguments need to benull
(so they can be filtered out in viaisNone
in https://github.com/ghedamat/ember-svg-jar/blob/v2.4.6/packages/ember-svg-jar/addon/utils/make-svg.js#L107).If argument value is
undefined
, it gets added to DOM, which may cause issues with arguments likewidth
andheight
.This PR fixes types to add
null
as allowed arg type.