Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null as arguments type #261

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Conversation

SergeAstapov
Copy link
Contributor

When using {{svg-jar}} helper, optional named arguments need to be null (so they can be filtered out in via isNone in https://github.com/ghedamat/ember-svg-jar/blob/v2.4.6/packages/ember-svg-jar/addon/utils/make-svg.js#L107).

If argument value is undefined, it gets added to DOM, which may cause issues with arguments like width and height.

This PR fixes types to add null as allowed arg type.

@SergeAstapov SergeAstapov changed the title Update types.ts Allow null as arguments type Oct 16, 2023
@SergeAstapov
Copy link
Contributor Author

@evoactivity would you be able to land and release "this as is"? CI seem unhappy due to There appears to be trouble with your network connection.

@evoactivity
Copy link
Owner

Yep, I'll be creating a release for this tomorrow.

@evoactivity evoactivity merged commit 4758d45 into evoactivity:master Oct 21, 2023
5 of 6 checks passed
@evoactivity
Copy link
Owner

I pushed the release for this just now. Looks like I'll be tasking ownership on the repo, I'm going to setup changesets so people with merge access will be able to release directly from the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants