Testing and a number of fixes #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests, fixes collections. Clarifies issues in README.
|
Better now? |
If data type is bigint, then read it as 64 bits item not as var int.
Fixed indentation;
|
@andreizet I added your bigint PR to this one and fixed its usage in collections and added a test for both, positive and negative bigint values. Okay with it? |
|
Sure ! |
|
@evseevnn okay to merge this one? Anything pending? |
evseevnn-zz
pushed a commit
that referenced
this pull request
Oct 20, 2014
Testing and a number of fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic testing of a number of types through TravisCI with phpunit (please add web-hook to your repository @evseevnn )
Also fixes a bunch of collection issues that popped up during testing.
I clarified in the Readme what are still known issues.
Looking forward to your feedback.