Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Reset error highlight on start #119

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

juliaogris
Copy link
Member

Reset error highlight on start (run), so that the error highlight so
that we accurately display new errors or no errors if they are gone.
Previously errors only got reset if the line was updated which
incorrectly kept error line highlight for follow-on errors, e.g.:

x := "foo"  // line 1: 'x' declared but not used
print y     // line 2: unknown variable name 'y'

Fixed as

x := "foo"  // 💣 error remained: line 1: 'x' declared but not used
print x     // no error

Now all errors get reset.

@github-actions
Copy link

github-actions bot commented Apr 16, 2023

firebase-deployment: https://evy-lang--119-6d8m59xw.web.app (2995c84)

Reset error highlight on start (run), so that the error highlight so
that we accurately display new errors or no errors if they are gone.
Previously errors only got reset if the line was updated which
incorrectly kept error line highlight for follow-on errors, e.g.:

	x := "foo"  // line 1: 'x' declared but not used
	print y     // line 2: unknown variable name 'y'

Fixed as

	x := "foo"  // 💣 error remained: line 1: 'x' declared but not used
	print x     // no error

Now all errors get reset.
@juliaogris juliaogris merged commit a667f3b into master Apr 17, 2023
@juliaogris juliaogris deleted the fix-error-highlights branch April 17, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants