all: Cleanup lexing, comments and sample #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve "Guess my Number" sample by reducing the lines of code and fixing a typo in the comments.
Clean up index.js by - grouping exported funcs (canvas ) - removing left over console.logs - adding a `.` to all comments
|
firebase-deployment: https://evy-lang--121-w5adllqf.web.app (74007db) |
camh-
approved these changes
Apr 18, 2023
pkg/lexer/lexer.go
Outdated
| @@ -191,15 +191,15 @@ func (l *Lexer) readIdent() string { | |||
|
|
|||
| func (l *Lexer) readString() (string, error) { | |||
| pos := l.pos | |||
| backslashCnt := 0 | |||
| escaped := false | |||
| for { | |||
| if l.cur == '\\' { | |||
There was a problem hiding this comment.
you could get "fancy" and just say escaped = l.cur == '\\' && !escaped. Perhaps that is a little too obtuse? (same in the JS too)
There was a problem hiding this comment.
yeah, i think even though this is a little "fancy" it is worth doing for the reduction in code size. updated.
Clean up empty string literal lexing in go - lexer - and in JS - editor syntax colouring lexer. In the editor we actually had an error for escaped `\"` which wasn't highlighted properly.
juliaogris
force-pushed
the
housekeeping
branch
from
e65e655
to
74007db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continains various minor cleanups: