Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evy: Add drawing style functions #123

Merged
merged 1 commit into from
Apr 23, 2023
Merged

evy: Add drawing style functions #123

merged 1 commit into from
Apr 23, 2023

Conversation

juliaogris
Copy link
Member

@juliaogris juliaogris commented Apr 23, 2023

Add drawing style functions stroke, fill, dash, and linecap defined in
the same terms as HTML canvas styling, with the addition of "none"
for stroke and fill.

New examples:

@github-actions
Copy link

github-actions bot commented Apr 23, 2023

firebase-deployment: https://evy-lang--123-x8t7erj2.web.app (eac2929)

@juliaogris juliaogris requested a review from camh- April 23, 2023 06:54
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have no idea how these new functions are called - e.g. what parameters does linecap take and what do they mean. Should this get documented somewhere? I guess so, but documentation is boring, so ok.

pkg/wasm/imports.go Outdated Show resolved Hide resolved
frontend/index.js Show resolved Hide resolved
pkg/evaluator/builtin.go Outdated Show resolved Hide resolved
@juliaogris
Copy link
Member Author

LGTM, but I have no idea how these new functions are called - e.g. what parameters does linecap take and what do they mean. Should this get documented somewhere? I guess so, but documentation is boring, so ok.

Yes, you are right. There are lots of undocumented builtins now. This needs a separate pass. (hope that's ok with you).

@juliaogris juliaogris force-pushed the evy-styles branch 3 times, most recently from a79f1dc to 00523e6 Compare April 23, 2023 08:33
Add drawing style functions stroke, fill, dash, and linecap defined in
the same terms as HTML canvas styling, with the addition of `"none"`
for stroke and fill.
@juliaogris juliaogris merged commit 1b5d505 into master Apr 23, 2023
@juliaogris juliaogris deleted the evy-styles branch April 23, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants