evaluator: Don't nest function scope inside other function scope #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camh-
force-pushed
the
fix-eval-func-scope
branch
from
06d3964
to
5e429b1
Compare
|
firebase-deployment: https://evy-lang--128-lq8bmabv.web.app (63e8b8a) |
juliaogris
approved these changes
Apr 30, 2023
pkg/evaluator/evaluator_test.go
Outdated
| print f | ||
| if true | ||
| f := "🎈" | ||
| print f |
There was a problem hiding this comment.
indentation seems a little off I think.
There was a problem hiding this comment.
ok. fixed I think. I had tab indenting when it was at 8-spaces, which perhaps you saw as 4 spaces depending on your github settings.
Do not nest a function scope inside another function scope, since we do
not look up variables across function scopes. A function scope should be
based on the global scope only (and this includes handler scopes too,
which are just a function in disguise).
This program would print "2" instead of "1" as `f2` was traversing the
scope of `f1` when looking up `a` to print. It should skip `f1` and go
straight to the global scope:
a := 1
func f1
a := 2
f2
end
func f2
print a
end
f1
camh-
force-pushed
the
fix-eval-func-scope
branch
from
5e429b1
to
63e8b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not nest a function scope inside another function scope, since we do
not look up variables across function scopes. A function scope should be
based on the global scope only (and this includes handler scopes too,
which are just a function in disguise).
This program would print "2" instead of "1" as
f2was traversing thescope of
f1when looking upato print. It should skipf1and gostraight to the global scope: