Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Fix function calls with indexed arguments #176

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

juliaogris
Copy link
Member

Fix function call parsing for arguments with index - maps, type assertions,
grouped expressions and arrays. We're here at a finicky bit of evy. Prior
to this PR we'd get a compile error for:

print {} []

error message:

line 1: unexpected whitespace before "["

Remove debug print in tests from previous PR.

Remove debug print in tests from previous PR. While at it improve naming
of the test case.
@github-actions
Copy link

github-actions bot commented Jul 24, 2023

firebase-deployment: https://evy-lang--176-yatzfrnc.web.app (c0ddebb)

Fix function call parsing for arguments with index - maps, type
assertions, grouped expressions and arrays. We're here at a finicky bit
of evy. Prior to this PR we'd get a compile error for:

	print {} []

error message:

	line 1: unexpected whitespace before "["
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 LGTM

@juliaogris juliaogris merged commit b7ee169 into master Jul 26, 2023
3 checks passed
@juliaogris juliaogris deleted the index-fix branch July 26, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants