all: Fix len func and improve errors #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment: https://evy-lang--197-m8nqw7ze.web.app (85852d7) |
camh-
approved these changes
Sep 5, 2023
Improve ErrVarNotSet error by changing it from an internal error to a runtime panic as there are legitimate ways in which to parse code that then runs using an unset variable. The new testcase covers this. While at it improve the error message and location where the error is reported.
Fix built-in len function for strings to use rune code, rather than bytes count. That means `len "✨"` now returns 1, rather than 3. However certain emojis are graphemes/clusters and still return counts greater than one such as flags or skin-coloured emojis.
juliaogris
force-pushed
the
fix-len-string
branch
from
c540b75
to
85852d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
been declared at call site.