parser: Prepare assignability refactor #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment: https://evy-lang--215-nz732yp9.web.app (250771d) |
camh-
approved these changes
Oct 25, 2023
| } | ||
| for _, input := range inputs { | ||
| parser := newParser(input, testBuiltins()) | ||
| _ = parser.parse() | ||
| assertNoParseError(t, parser, input) | ||
|
|
||
| assert.Equal(t, NONE_TYPE, UNTYPED_ARRAY.Sub) |
There was a problem hiding this comment.
The commit message says "fix whitespace", but you're removing an assertion. Was this an accident and you only meant to remove the blank line?
There was a problem hiding this comment.
That was on purpose, but I guess I can leave it in.
pkg/parser/type.go
Outdated
| } | ||
| return combinedT | ||
| } | ||
|
|
There was a problem hiding this comment.
nit nit: extra blank line at EOF. It does get removed in the next commit though, so not really a worry
Refactor combineTypes from a method on the parser to a standalone function as it makes no use of the parser. Move it to pkg/parser/type.go as it more naturally fits there.
Remove sameComposite as it is only used in one place and can be inlined as a oneliner.
Remove ILLEGAL type as it should never be exposed and handled internally.
Add missing godoc comment to Type.String(). It's a mystery why golangci-lint hasn't picked up on this earlier.
Fix whitespace of evy source code in parser tests.
juliaogris
force-pushed
the
assignability-prep
branch
from
f25d679
to
250771d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In yet another attempt to wrangle the complexities around assignability, shave
off a bunch of preparatory commits:
combineTypesinto itsameCompositein favour of inlining