Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctest: Exit with an error when errors occur #220

Merged
merged 2 commits into from
Oct 26, 2023
Merged

doctest: Exit with an error when errors occur #220

merged 2 commits into from
Oct 26, 2023

Conversation

camh-
Copy link
Member

@camh- camh- commented Oct 26, 2023

Ensure awk exits with an error when there is an error in an evy code block.
Prior to this, an error was printed but awk still exited with 0 allowing CI
and make doctest to continue.

Emit a document line number when an error is reported to make it easier to
locate where the error is.

Change the tagging of evy code that is expected to exit with an error
from evy expect_err to evy:err. Update the builtins docs to use this
(and fix a misspelling at the same time that mismarked a block).

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

firebase-deployment: https://evy-lang--220-cu0d4gmo.web.app (5d23eb6)

Copy link
Member

@juliaogris juliaogris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - as far as I can comment on awk. thanks for fixing it.

any chance we could rename it to evy:err ?

@camh-
Copy link
Member Author

camh- commented Oct 26, 2023

any chance we could rename it to evy:err ?

Done. PTAL

Copy link
Member

@juliaogris juliaogris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 💚 - thanks for doing this, I appreciate it heaps!

Change the tagging of evy code that is expected to exit with an error
from `evy expect_err` to `evy:err`. Update the builtins docs to use this
(and fix a misspelling at the same time that mismarked a block.
Ensure awk exits with an error when there is an error in an evy code
block. Prior to this, an error was printed but awk still exited with 0
allowing CI and `make doctest` to continue.

Emit a document line number when an error is reported to make it easier
to locate where the error is.
@camh- camh- merged commit 27993ed into main Oct 26, 2023
3 checks passed
@camh- camh- deleted the doctest-errors branch October 26, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants