Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Deploy to prod and stage on merge to main #231

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

juliaogris
Copy link
Member

@juliaogris juliaogris commented Jan 2, 2024

Deploy to prod and now also to stage on merge to main. We do this via
separate GitHub environments: prod and stage and different GitHub actions
job using different FIREBASE_SERVICE_ACCOUNT_EVY_LANG secrets wired to
the corresponding firebase prod and stage environments.

When the CI job (not the release job!) is run on main, rather than
pull-request, we deploy to https://evystage.dev and its live channel,
rather than the PR preview channel. We don't post preview channels to any
PR. This is done via updates to the firebase-deploy script.

While at it, add a minor, non-functional improvement to sed expression in
firebase-deploy script.

I've setup stage and prod GitHub environments prod and stage separately via
clicky-clicky-admin, hopefully using the correct Firebase Service Account secrets
and the correct branch protection rule for prod.


Fixes evylang/todo#46

Improve regexp in href/URL replacement deploy script. There is no functional
change.
@juliaogris juliaogris requested a review from camh- January 2, 2024 02:06
Deploy to prod and now also to stage on merge to main. We do this via separate
GitHub environments: prod and stage and different GitHub actions job using
different `FIREBASE_SERVICE_ACCOUNT_EVY_LANG` secrets wired to the
corresponding firebase prod and stage environments.

When the CI job (not the release job!) is run on `main`, rather than
pull-request, we deploy to https://evystage.dev and its live channel, rather
than the PR preview channel. We don't post preview channels to any PR. This
is done via updates to the firebase-deploy script.

Issue: evylang/todo#46
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥒

@juliaogris juliaogris merged commit 6508dad into main Jan 2, 2024
3 checks passed
@juliaogris juliaogris deleted the housekeeping branch January 2, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy to evystage.dev on merge to main
2 participants