Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the cicd workflow into stage and prod workflows #244

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

camh-
Copy link
Member

@camh- camh- commented Jan 15, 2024

Split up the cicd workflow so that a PR does not show a bunch of
irrelevant skipped steps on it. The new stage workflow is triggered on
a pull request and can be called from another workflow. The prod
workflow is triggered on a push to main, calls the stage workflow
and does the deployment to prod.

Docs: https://docs.github.com/en/actions/using-workflows/reusing-workflows

@camh-
Copy link
Member Author

camh- commented Jan 15, 2024

I did a test of temporarily modifying prod.yaml to be run on this branch as well as main and disabled the actual prod deployment jobs just to test that the workflow calling was working ok and the secrets were accessible to the jobs. All looks good, so undrafting now.

Copy link
Member

@juliaogris juliaogris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I so love this! So good. Thank you Cam for sharing you GHA YAML skills. 💚

.github/workflows/prod.yaml Show resolved Hide resolved
Split up the cicd workflow so that a PR does not show a bunch of
irrelevant skipped steps on it. The new `stage` workflow is triggered on
a pull request and can be called from another workflow. The `prod`
workflow is triggered on a push to `main`, calls the `stage` workflow
and does the deployment to prod.

Docs: https://docs.github.com/en/actions/using-workflows/reusing-workflows
@camh- camh- merged commit 2b5936e into main Jan 15, 2024
2 checks passed
@camh- camh- deleted the split-cicd branch January 15, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants