ci: Fix prod workflow to checkout on deploy #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkout the repository on the prod/deploy job so that it can actually work. This was split off the release job which does the checkout - the split needed to add the checkout to the new job.
|
firebase-deployment for f135692 |
camh-
commented
Jan 15, 2024
| @@ -30,6 +30,9 @@ jobs: | |||
| needs: release | |||
| environment: prod | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
we use fetch-depth: 0 everywhere (meaning checkout all history), but I think it might only be needed for release? i'll leave this here for now, but perhaps we should check all of these out (pun intended).
There was a problem hiding this comment.
It is need for deploy targets as well as it creates version.json
There was a problem hiding this comment.
I think could do without on ci maybe. Not sure. Will try on tractor
There was a problem hiding this comment.
It is needed for ci, because that does a build and it uses $(VERSION) in a linker flag which is based on the tags which need history.
juliaogris
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkout the repository on the prod/deploy job so that it can actually
work. This was split off the release job which does the checkout - the
split needed to add the checkout to the new job.