frontend: Introduce rests.css #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for 2755bfe |
juliaogris
commented
Jan 22, 2024
There was a problem hiding this comment.
The diff here is slight relocation of the ❌ in the top right corner as a result of
img, picture, video, canvas, svg {
display: block;
max-width: 100%;
}There was a problem hiding this comment.
The swipe and onion skin options below the images show this.
I really like this, 👏 GitHub.
juliaogris
force-pushed
the
refactor-css
branch
from
593ca4e
to
fa7378e
Compare
juliaogris
force-pushed
the
split-styles
branch
from
7b36051
to
0dd6742
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
fa7378e
to
ebcc40c
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
ebcc40c
to
e22c781
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
e22c781
to
f1df292
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
f1df292
to
99da016
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
99da016
to
c5093f4
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
c5093f4
to
7ce0304
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
7ce0304
to
2794899
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
2794899
to
faaf8e8
Compare
juliaogris
force-pushed
the
split-styles
branch
5 times, most recently
from
7f80728
to
0b6618d
Compare
Rename URLs https://evy.dev/play to https://play.evy.dev as we want to make play.evy.dev the canonical place to find the evy playground.
juliaogris
force-pushed
the
refactor-css
branch
from
faaf8e8
to
64f584b
Compare
juliaogris
force-pushed
the
refactor-css
branch
from
64f584b
to
ccaaf55
Compare
Mark `frontend/css/fonts/*.*.woff2` font files, which have a version in their filename, e.g. `firacode-latin.v22.woff`, with the usual one year, i.e. maximum cache expiry header. We don't expect to be updating these files, only adding new versions with new names. We've renamed the files from *-vN.woff, to *.vN.woff, e.g. firacode-latin.v22.woff, so that we can use the same pattern as other hashed files for extended expiry.
Introduce resets.css to be reused in other *.html files. Using a typical resets.css file shook out a couple of minor visual bugs, e.g. incorrect font in an input element.
Rename CSS variables to closer correspond to the CSS properties for which they are used, e.g. rename -ff to --font-family. This seems to be the idiomatic way of doing CSS variables and it seems also easier to remember.
Introduce root.css with global style related color and font-family related values to be reused in other *.html files.
Modernize import/export syntax to ES6. Require was a pre-ES6, node way of importing modules and is not needed anymore. Link: https://stackoverflow.com/questions/31354559/using-node-js-require-vs-es6-import-export
Move playground end-to-end tests to e2e/play so that we can make space for a landing page in the root directory. In a follow up commit we will also move the frontend source code to /play.
Shorten test case names for better readability in test error messages.
juliaogris
force-pushed
the
refactor-css
branch
from
ccaaf55
to
2755bfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce rests.css and root.css to be reused in other *.html files.
We are using a typical resets.css file, which shook out a couple of
minor visual bugs, e.g. incorrect fontin an input element.
Introduce roots.css for global CSS style variables, such as colors and fonts
Update *.woff2 files with 1 year cache expiry in firebase config.
Refactor e2e tests in preparation for landing page and separate play.evy.dev tests.