canvas: Fix Nan in move event #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not remove fragment/hash for share URLs until you edit the shared example. Quite commonly I open a share link, check that something still works and then I want to copy the URL which is gone. Fix it by keeping the URL for now.
We noticed an issue for the following evy example, where the program would crash with last reporting a NaN for a the move x-coordinate. I have no idea how this function ever worked, but now it does 😅. Issue: #264 Example: https://play.evy.dev/#content=H4sIAAAAAAAAE3VRTWvDMAy9+1eI7JIuFJLuFug/6G2XjZCD6ziZmWNDPlb730+W0kAGM9iypaenJyvUTevWUcTNKqvlBNndSvWdCdH7CSbpBg2XUgCuAFfcBTRlS++I77i9teuEmPVw025YvqC+wpsQD9PhvRLKW+TKXnpa9xLJvYPR/2gINVaGmE7i7Cb5wCKRCfvVKXaNfp31B4Hp+rlnHFU/Od71MGq3QLllblkUT42ZJJG7y612EE7nioJ/CUxRQWhMCxEPQiRlR3U7lvQF47gptiwppHoYgTOxsTMmZyTnzo6SrE5+uUh3SZgu8O8nEU+OXPmZoSd4hf3feSwMZN58RvMPkAdw6M0ax64CFUeyPIpf+sznyiwCAAA=
|
firebase-deployment for 34a0e51 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed an issue for the following evy example, where the program would
crash with last reporting a NaN for a the move x-coordinate. I have no idea
how this function ever worked, but now it does 😅.
While at it, remove Hash/fragment removal when accessing shared code snippets.
I've found myself wanting to copy that fragment several times now directly
from the address bar so I'm putting it back.
Issue: #264
Example:
https://play.evy.dev/#content=H4sIAAAAAAAAE3VRTWvDMAy9+1eI7JIuFJLuFug/6G2XjZCD6ziZmWNDPlb730+W0kAGM9iypaenJyvUTevWUcTNKqvlBNndSvWdCdH7CSbpBg2XUgCuAFfcBTRlS++I77i9teuEmPVw025YvqC+wpsQD9PhvRLKW+TKXnpa9xLJvYPR/2gINVaGmE7i7Cb5wCKRCfvVKXaNfp31B4Hp+rlnHFU/Od71MGq3QLllblkUT42ZJJG7y612EE7nioJ/CUxRQWhMCxEPQiRlR3U7lvQF47gptiwppHoYgTOxsTMmZyTnzo6SrE5+uUh3SZgu8O8nEU+OXPmZoSd4hf3feSwMZN58RvMPkAdw6M0ax64CFUeyPIpf+sznyiwCAAA=
Fixed at:
https://evy-lang-stage-play--267-gmiw5cd8.web.app/#content=H4sIAAAAAAAAE3VRTWvDMAy9+1eI7JIuFJLuFug/6G2XjZCD6ziZmWNDPlb730+W0kAGM9iypaenJyvUTevWUcTNKqvlBNndSvWdCdH7CSbpBg2XUgCuAFfcBTRlS++I77i9teuEmPVw025YvqC+wpsQD9PhvRLKW+TKXnpa9xLJvYPR/2gINVaGmE7i7Cb5wCKRCfvVKXaNfp31B4Hp+rlnHFU/Od71MGq3QLllblkUT42ZJJG7y612EE7nioJ/CUxRQWhMCxEPQiRlR3U7lvQF47gptiwppHoYgTOxsTMmZyTnzo6SrE5+uUh3SZgu8O8nEU+OXPmZoSd4hf3feSwMZN58RvMPkAdw6M0ax64CFUeyPIpf+sznyiwCAAA=