bytecode: Implement unary expressions #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for 5ec0bbf |
juliaogris
reviewed
Feb 20, 2024
There was a problem hiding this comment.
looks pretty good to me too, just a couple of thoughts.
waiting for @camh- here too.
Rossiar
force-pushed
the
compiler-unary
branch
from
d4c1313
to
32ea7aa
Compare
Rossiar
force-pushed
the
compiler-unary
branch
from
32ea7aa
to
7f8edbd
Compare
juliaogris
reviewed
Feb 21, 2024
There was a problem hiding this comment.
@Rossiar - if you rebase and take this out of draft, i think we are good.
Rossiar
force-pushed
the
compiler-unary
branch
from
7f8edbd
to
4461f7e
Compare
Rossiar
force-pushed
the
compiler-unary
branch
from
4461f7e
to
4796560
Compare
This change adds the 'not' and 'minus' unary operators to the compiler and vm. Co-authored-by: joshcarp <joshcarp@users.noreply.github.com> Co-authored-by: pgmitche <pgmitche@users.noreply.github.com>
Rossiar
force-pushed
the
compiler-unary
branch
from
4796560
to
5ec0bbf
Compare
camh-
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the 'not' and 'minus' unary operators
to the compiler and vm.
Co-authored-by: joshcarp joshcarp@users.noreply.github.com
Co-authored-by: pgmitche pgmitche@users.noreply.github.com