bytecode: Implement equality and inequality operators #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for c932ed8 |
Rossiar
force-pushed
the
compiler-unary
branch
3 times, most recently
from
4796560
to
5ec0bbf
Compare
Rossiar
force-pushed
the
compiler-equality
branch
from
a94d1b3
to
3ee21b6
Compare
The equality operators are the only operators that can operate across all evy types. Therefore it makes sense to utilise the value interface and its Equals function to generically handle this expression for all evy types. The alternative is to create separate equality and inequality opcodes for each evy type, which would introduce many new opcodes and repeated code in this package. Co-authored-by: joshcarp <joshcarp@users.noreply.github.com> Co-authored-by: pgmitche <pgmitche@users.noreply.github.com>
Rossiar
force-pushed
the
compiler-equality
branch
from
3ee21b6
to
c932ed8
Compare
juliaogris
approved these changes
Feb 22, 2024
camh-
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The equality operators are the only operators that can
operate across all evy types. Therefore it makes sense
to utilise the value interface and its Equals function
to generically handle this expression for all evy types.
The alternative is to create separate equality and
inequality opcodes for each evy type, which would
introduce many new opcodes and repeated code in this
package.
Co-authored-by: joshcarp joshcarp@users.noreply.github.com
Co-authored-by: pgmitche pgmitche@users.noreply.github.com