Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update markdown formatting of docs #287

Merged
merged 3 commits into from
Mar 7, 2024
Merged

docs: Update markdown formatting of docs #287

merged 3 commits into from
Mar 7, 2024

Conversation

juliaogris
Copy link
Member

@juliaogris juliaogris commented Mar 6, 2024

Update markdown formatting of docs in mostly cosmetic ways:

  • Remove horizontal lines between samples of builtin documentation
  • Turn h4 headers into h3 headers in the usage documentation

Horizontal lines and h4 were motivated by the way GitHub renders markdown. As
we are shifting to evy.dev we don't need these anymore as we have full
control of styles and spacing.

While at it, also add a small fix to docs template to link to favicon
and logo via relative path.

Also rename sidemenu to sidebar everywhere as a preparatory step
for adding a custom docs sidebar. Sidebar seems to be the more commonly
used technical term.

Update markdown formatting of docs in mostly cosmetic ways:

- Remove horizontal lines between samples of builtin documentation
- Turn h4 headers into h3 headers in the usage documentation

Horizontal lines and h4 were motivated by the way GitHub renders markdown. As
we are shifting to evy.dev we don't need these anymore as we have full
control of styles and spacing.
Fix favicon and logo image paths to relative to the current docs page. This
will allow for image display on docs.evy.dev and for docs pages in
sub-directories.
Rename all sidemenu to sidebar is this seems to be the more commonly used
term. On the GitHub wikis for example, _sidebar.md holds the contents of the
sidebar. In a follow up commit we will use the same convention for providing
the docs sidebar and for consistency we will start renaming here as a
preparatory step.
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥗 Looks good from what I see.

@juliaogris juliaogris merged commit 6be224c into main Mar 7, 2024
3 checks passed
@juliaogris juliaogris deleted the md-docs-udpate branch March 7, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants