docsite: Add theme toggle #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for aad8650 |
juliaogris
force-pushed
the
theme-toggle
branch
from
d7287dd
to
bed57a5
Compare
juliaogris
force-pushed
the
theme-toggle
branch
from
bed57a5
to
402cadc
Compare
juliaogris
force-pushed
the
footer-icons
branch
from
dc60494
to
d6dc769
Compare
juliaogris
force-pushed
the
theme-toggle
branch
from
402cadc
to
1a75932
Compare
juliaogris
force-pushed
the
footer-icons
branch
from
d6dc769
to
76fbe48
Compare
Update SVG files with version number in filename so we can include them in our long expire cache policy. While at it, change the evy-e.svg DOM node from <embed> (not officially supported, dates back to Flash days), to <object>. This also explains previous strange behavior with embed on ios. We cannot just use an <img> for this SVG file as that does not render it interactive. Link: https://vecta.io/blog/best-way-to-embed-svg Link: https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web Commit-group: 1/2
Update SVG files with version number in filename so we can include them in our long expire cache policy. While at it, change the evy-e.svg DOM node from <embed> (not officially supported, dates back to Flash days), to <object>. This also explains previous strange behavior with embed on ios. We cannot just use an <img> for this SVG file as that does not render it interactive. Link: https://vecta.io/blog/best-way-to-embed-svg Link: https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web Gen-command: make docs Commit-group: 2/2
Refactor CSS variables by grouping them unter :root in preparation for light theme. Also rename "primary" to "accent" (the blueish link color) as this is the more accurate design term.
Fix color of code links - it was white where it was supposed to be the sidebar color.
Add theme toggle to docs and template in top right corner. Theme doc stores user preferences in local-storage, and takes OS prefers dark-theme into account if set. For the docs page if nothing is set it defaults to light. Minimal demo: frontend/css/switch.html Commit-group: 1/2
Add theme toggle to docs and template in top right corner. Theme doc stores user preferences in local-storage, and takes OS prefers dark-theme into account if set. For the docs page if nothing is set it defaults to light. Minimal demo: frontend/css/switch.html Fixes: evylang/todo#71 Gen-command: make docs Commit-group: 2/2
juliaogris
force-pushed
the
theme-toggle
branch
from
1a75932
to
aad8650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add theme toggle to docs and template in top right corner. Theme doc stores
user preferences in local-storage, and takes OS prefers dark-theme into
account if set. For the docs page if nothing is set it defaults to light.
Refactor CSS color variables and version SVG files in preparatory steps.
Fixes: evylang/todo#71
Preview at https://evy-lang-stage--302-2ikl2shu.web.app/preview/